Skip to content

Made dev compose file so u don't have to rebuild everytime you make changes#77

Open
tmcnulty387 wants to merge 1 commit intoComputerScienceHouse:mainfrom
tmcnulty387:main
Open

Made dev compose file so u don't have to rebuild everytime you make changes#77
tmcnulty387 wants to merge 1 commit intoComputerScienceHouse:mainfrom
tmcnulty387:main

Conversation

@tmcnulty387
Copy link
Member

…hanges

What

Added docker-compose.dev.yaml to run the vote container during development

Why

So you don't have to rebuild the container when you change code during development

Test Plan

Just changed the docker compose file and README, didn't run Go tests. I verified that it actually works by adding print statements in main, output does change when rerunning podman compose -f docker-compose.dev.yaml up

Env Vars

Didn't change, just copied existing compose file and added this

  vote:
    build:
      context: .
      target: build
    working_dir: /src
    command: ["go", "run", "./..."]
    volumes:
      - type: bind
        source: .
        target: /src

Checklist

  • Tested all changes locally

@tmcnulty387
Copy link
Member Author

Fixes #76

@tmcnulty387
Copy link
Member Author

I'll add the other commits in a different PR, force push was a reset hard to docker compose commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant